Repository navigation
Conversation
dnlbui
added this pull request to stack #1759
October 6, 2026 21:09
dnlbui
force-pushed
the
codex/1748-phase-2-confirmation
branch
from
October 7, 2026 21:13
936304f to
262cce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
EVM transfers now use a dedicated confirmation modal with their own network, fee, signing notice, and USD estimate elements.
Fixed Flow
Review an EVM transfer from its Send form: confirmation shows the selected asset, recipient, network, and native fee immediately. Cancel or close returns without approving the transfer. LIB confirmation retains its own fields and behavior.
Why
Separate confirmation ownership prevents EVM rendering and dismissal handlers from modifying LIB confirmation state.
Validation
Local tests remain ignored and are not included in this PR.
app.jsandevm-assets.js;git diff --check.node tests/lib-evm-modal-separation.browser.test.mjs --phase=2.node tests/evm-send-fee-usd.browser.test.mjs.Browser checks cover native/ERC20 assets, missing prices, small fees, cancellation, notes, duplicate warnings, and desktop/mobile layouts using simulated preparation. No funded transfer was broadcast.
Stack
Phase 2 of four phases; depends on phase 1. Its base is
codex/1748-phase-1-send, so this diff contains only confirmation changes. Merge phase 1 first, then retarget this PR tomain.Refs #1748