Repository navigation
fix: upgrade vulnerable seroval to 1.6.3 - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I upgraded the admin panel's transitive
serovaldependency from 1.5.0 to Mend's recommended 1.6.3 to address the three vulnerabilities reported in https://github.com/ClickHouse/security-vulnerabilities/issues/1021 (CVE-2026-104845, CVE-2026-59940, and CVE-2026-104846).serovalto 1.6.3 through a root override so every dependency path uses the patched version, including Solid's exact 1.5.0 requirement.bun.lockwith the published 1.6.3 integrity hash, preserving all unrelated package versions.The dependency enters through
@tanstack/react-router-devtools→@tanstack/router-core,@tanstack/react-start→ its client/server cores, and@tanstack/react-devtools→@tanstack/devtools→solid-js, including theseroval-pluginspeer path.bun pm why serovalnow resolves these paths to 1.6.3. Mend should re-scan the merged dependency tree to confirm closure.Change Type
Testing
bun install --frozen-lockfile.bun pm why serovalresolves a single version, 1.6.3.bunx tsc --noEmit.bun run test: 27 files, 1,215 tests.bun run build: client and server production bundles. Build reports browser externalization ofcryptoand large chunk warnings.git diff --check.Test Configuration:
Bun 1.4.2; dedicated worktree based on current
origin/main(bb88594).Checklist