Repository navigation
🔒 fix: Upgrade Vulnerable js-yaml to 4.3.2 - #153
Merged
Merged
Conversation
dustinhealy
marked this pull request as ready for review
October 12, 2026 14:38
AtefBellaaj
approved these changes
Oct 14, 2026
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
js-yamlto 4.3.2 and override transitive copies so the admin panel uses one patched version, including the exact version requested byxmlbuilder2. This addresses the reportedjs-yamlsecurity advisories without changing unrelated dependencies.Change Type
Testing
bun install --frozen-lockfilebun pm why js-yaml— all paths resolve to 4.3.2bunx tsc --noEmitbun run test— 27 files, 1,215 tests passedbun run build— client and server bundles builtgit diff --checkArea involved and manual test results
Test Configuration
Bun 1.3.3 and a local development admin panel. The build reports browser externalization of
cryptoand large bundle warnings.Checklist