Repository navigation
fix: allow workers to drain executions before shutdown - #332
Open
jacksonriding wants to merge 2 commits into
Open
jacksonriding wants to merge 2 commits into
jacksonriding wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker currently forces exit after 30 seconds even though ordinary jobs can run for five minutes. Raising only the service timer would still leave Docker/Kubernetes free to kill it earlier, and the combined supervisor currently stops the sandbox before its worker drains.
Derive worker shutdown time from the existing execution/cleanup budget, retaining the longer hosted-app budget. Keep the API-only default at 30 seconds and support
CODEAPI_SHUTDOWN_TIMEOUT_MSthrough the existing positive-integer parser, with protection against timer overflow.Align the supplied deployment paths: Compose workers get 400 seconds; Helm worker pods derive stop grace from the configured job timeout plus 100 seconds, with an explicit override. Stop the combined container's worker before its sandbox. Bump the chart to 0.3.3.
Validation: