Skip to content

feat: Support XLSB (Excel Binary Workbook) Sandbox Artifacts #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gafda wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

feat: Support XLSB (Excel Binary Workbook) Sandbox Artifacts #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build-packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ install_python_packages() {
beautifulsoup4 \
tabulate \
xlrd \
python-calamine \
numba \
patsy \
numexpr \
Expand Down
1 change: 1 addition & 0 deletions docker/package-init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ if [ -f "$PIP_PATH" ]; then
beautifulsoup4 \
tabulate \
xlrd \
python-calamine \
numba \
patsy \
numexpr \
Expand Down
9 changes: 9 additions & 0 deletions packages/code/src/protocol.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,15 @@ test('bridge artifact policy and media types match the hardened gateway contract
assert.equal(bridgeArtifactMediaType('preview.png'), 'image/png');
assert.equal(bridgeArtifactMediaType('reports/result.json'), 'application/json');
assert.equal(bridgeArtifactMediaType('Dockerfile'), 'application/octet-stream');
// XLSB (Excel Binary Workbook) — sandboxed code can produce these via
// `pd.read_excel(path, engine='calamine')`-backed workflows; the egress
// gateway must accept them with the correct Content-Type rather than
// falling back to application/octet-stream.
assert.equal(isSupportedBridgeArtifactName('report.xlsb'), true);
assert.equal(
bridgeArtifactMediaType('report.xlsb'),
'application/vnd.ms-excel.sheet.binary.macroenabled.12',
);
});

test('linked-worktree lanes nest beneath their checkout key and conflict only with it', () => {
Expand Down
5 changes: 3 additions & 2 deletions packages/code/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const BRIDGE_ARTIFACT_EXTENSIONS = new Set([
'.pptx',
'.xls',
'.xlsx',
'.xlsb',
'.odt',
'.ods',
'.odp',
Expand Down Expand Up @@ -241,8 +242,8 @@ const BRIDGE_ARTIFACT_MEDIA_TYPES: Readonly<Record<string, string>> = {
'.woff': 'font/woff',
'.woff2': 'font/woff2',
'.xls': 'application/vnd.ms-excel',
'.xlsx':
'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'.xlsx': 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
'.xlsb': 'application/vnd.ms-excel.sheet.binary.macroenabled.12',
'.xml': 'application/xml',
'.yaml': 'application/yaml',
'.yml': 'application/yaml',
Expand Down