Feat/ghcr static build#43
Conversation
Signed-off-by: henmohr <henriquemohr@redes.ufsm.br>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6147de82e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| NEXTCLOUD_VERSION: ${NEXTCLOUD_VERSION:-stable-fpm} | ||
| volumes: | ||
| - ./volumes/nextcloud:/var/www/html | ||
| - ./volumes/backups:/backups |
There was a problem hiding this comment.
For the default compose stack, this bind mount points /backups at ./volumes/backups, while the new committed/chowned placeholder and the docs use ./backups (and the Garage compose file mounts ./backups). On a fresh checkout Docker will create ./volumes/backups as a root-owned host directory; the Nextcloud entrypoint runs hooks as www-data, so the pre-upgrade redirect to /backups/app_list.old fails with permission denied and aborts upgrades unless operators manually discover and chown the different path.
Useful? React with 👍 / 👎.
|
|
||
| cleanup() { | ||
| if [ "$maintenance_enabled" -eq 1 ]; then | ||
| php occ maintenance:mode --off >/dev/null 2>&1 || true |
There was a problem hiding this comment.
Because this cleanup trap runs on every exit, a successful pre-upgrade turns maintenance mode off immediately after creating the dump. The Nextcloud Docker entrypoint runs pre-upgrade before its occ upgrade step and post-upgrade after that step, so this defeats the documented flow where pre-upgrade enables maintenance and post-upgrade disables it; the instance can be available during the upgrade gap and the post-upgrade repair/app-update commands run without maintenance mode.
Useful? React with 👍 / 👎.
1 participant
No description provided.