Repository navigation
fix: pass app link, CORS and ASN settings through docker-compose.yml - #101
Merged
Merged
Conversation
The compose file lists the container's environment explicitly and has no env_file, so IOS_TEAM_ID, IOS_BUNDLE_ID, ANDROID_PACKAGE_NAME, ANDROID_SHA256_FINGERPRINTS, CORS_ORIGIN and ASN_DB_PATH set in .env never reached the container. The .well-known routes returned a 404 even when the values were set. Unset values behave as before, since Core treats an empty value as unset for each of these.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.ymllists the container's environment explicitly and has noenv_file, so these settings in.envnever reached the container:IOS_TEAM_ID,IOS_BUNDLE_IDANDROID_PACKAGE_NAME,ANDROID_SHA256_FINGERPRINTSCORS_ORIGINASN_DB_PATHAs a result,
/.well-known/apple-app-site-associationand/.well-known/assetlinks.jsonreturned a 404 even with the values set, andCORS_ORIGINstayed at*.Behavior change
Anyone with these values already in
.envwill see them take effect on the nextdocker compose up, including a stricterCORS_ORIGINif they set one. Unset values behave as before, because Core treats an empty value as unset for each of these.Testing
docker compose configis valid with the variables unset, and shows each value on the container when set. I didn't start the stack.