Repository navigation
test(e2e): check that a link opened through the SDK is stored as a human click - #13
Merged
Merged
Conversation
…man click The server records a click when the SDK resolves a link the app opened. Check, for a link opened while the app runs and one that launches it, that exactly one click is stored and that it is not classified as a bot; and that the browser tap before an install is stored as human.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server records a click when the SDK resolves a link the app opened. The end-to-end scenarios now check what it stored:
These are database checks, so they run when
LF_E2E_DATABASE_URLis set. The SDK resolve's click is classified as human by@linkforty/core1.35.3 and later; on an older server the Android checks fail (Android sends OkHttp's user agent, which earlier versions classified as a bot).scenarios.mjsandharness.mjsare identical in the iOS and Android repos.Results against a local server on
@linkforty/core1.35.3: 66 passed, 0 failed on both platforms. Against 1.35.0 the two Android open checks fail with "0 human, 1 bot".