Repository navigation
test(fingerprint): cover the reported device language - #12
Merged
Merged
Conversation
Moves the formatting of the device locale into FingerprintCollector.languageTag and tests it: language or language-REGION, script subtags dropped, 3-digit regions kept, at most 10 characters, and read from the platform dispatcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fingerprint's
languageislanguageorlanguage-REGION, the same form the other SDKs and the server use. This adds tests for it.FingerprintCollector.languageTag(Locale)(@visibleForTesting) holds the formatting that_getLanguage()did inline; behavior is unchanged.en-US,en,en-ES,es-419andfil-PHare reported as they are.zh_Hans_CN→zh-CN,zh_Hant_TW→zh-TW,sr_Latn_RS→sr-RS,zh_Hans→zh.ll[-RR].localeTestValue).The engine hands the locale over already split into language, script and country, without Android's
-u-…extensions or iOS's@keywords, so those can't reach the fingerprint.Tests
flutter test: 125 passed.flutter analyze: no issues.dart format --set-exit-if-changed: clean.