Repository navigation
Conversation
Closes LintError#88 Give the public/secret copy buttons and secret-key visibility toggle accessible names (and aria-pressed on the toggle). Clarify Header theme and menu button labels with aria-pressed / aria-expanded. Leave Eye icon swap for LintError#90 and Input labels for LintError#89.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Icon-only controls in the Stellar wallet (copy public/secret key, secret-key visibility toggle) had no accessible names. This PR adds
aria-labels,type=\"button\", andaria-pressedon the visibility toggle. Header theme/menu buttons already had labels; those are clarified with state (aria-pressed/aria-expanded).Closes #88
Out of scope
<label>wiring → left for Associate labels with the send form inputs #89aria-labelTesting
npm test— 16 passed (existing stellar util suite)