Repository navigation
chore: migrate remaining CLI process callers to the Effect v4 core - #1069
Merged
Merged
Conversation
This was referenced Sep 27, 2026
zxch3n
force-pushed
the
feat/effect-process-callers
branch
from
October 9, 2026 04:59
8969b85 to
d21a6bc
Compare
zxch3n
added this pull request to stack #1354
October 9, 2026 09:11
zxch3n
removed this pull request from stack #1354
October 9, 2026 09:25
zxch3n
added this pull request to stack #1356
October 9, 2026 09:37
zxch3n
force-pushed
the
feat/effect-process-callers
branch
3 times, most recently
from
October 9, 2026 11:34
9e5f580 to
de93693
Compare
zxch3n
force-pushed
the
feat/effect-process-callers
branch
3 times, most recently
from
October 9, 2026 14:40
b7b9fd0 to
ad4cfaf
Compare
Consolidate this layer for cascading rebases; retain its reviewed file contents. Model: gpt-6
zxch3n
force-pushed
the
feat/effect-process-callers
branch
from
October 9, 2026 15:35
a726e9d to
196fcb5
Compare
zxch3n
marked this pull request as ready for review
October 9, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Problem / pressure
The remaining CLI callers could bypass the ACP foundation and keep a second process implementation alive.
Summary
yield* handle.kill()while rejecting direct Node child signals.pnpm check, catching process libraries, dynamic imports and direct kill forms.The inherited v4 runtime and process core are not changes introduced by this PR.
Electron, supervisor, shared helpers and review helper migrate in the next PR.
Visual explanation
Before / after
Test plan
pnpm format,pnpm check,pnpm format:check, andpnpm run docs check.GIT_CONFIG_*,GIT_EXEC_PATH,LODY_GIT_*).Stack
The Effect v4 baseline (#1070) and lifecycle plans (#1355) are merged into main.
Use GitHub's native stack merge workflow, bottom to top. Each PR describes only
its own increment; all implementation layers use Effect 4.0.2.
Ablation-based simplification
Removed the literal command-builder test and its test-only export. Shell and daemon timeout coverage now uses explicit startup and virtual time. Disabling command grouping fails the retained shell timeout case.
Legacy execution boundary
The shared execution facades now carry a Legacy suffix and @deprecated: runCommandTextLegacy, runCommandTextSyncLegacy, startProcessLegacy, terminateChildTreeLegacy, signalChildTreeNowLegacy, isPidAliveSyncLegacy, probePidSyncLegacy, makeProcessRunnerLegacy and runPromiseSquashedLegacy. The Promise runner and manually owned handle types are ProcessRunnerLegacy and ProcessHandleLegacy. Old exports are removed and callers use full names; core Effect APIs, Layer builders and pure helpers keep their names. New Effect workflows compose core APIs and execute at their owning application entry point. The guard rejects retired imports/exports and aliases hiding Legacy. Cancellation and cleanup behavior are unchanged. The API and CLI migration belong here; cross-runtime consumers are updated in #1348.