Skip to content

chore: consolidate auth and session operation analytics - #1360

Merged
Leeeon233 merged 2 commits into
mainfrom
chore/simplify-auth-session-analytics
Oct 9, 2026
Merged

Leeeon233 merged 2 commits into
mainfrom
chore/simplify-auth-session-analytics

Conversation

@Leeeon233

Copy link
Copy Markdown
Contributor

Related issue

Problem / pressure

The authenticated route emitted app/active and app/auth_ready consecutively with identical properties. Session controls also emitted request events before an existing result/open event. This is source-level redundancy; aggregate observations do not establish production duplication rates or prove failure is impossible.

Summary

Remove app/auth_ready, session/stop_requested, session/queue_item_reorder_requested, and session/search_open_requested. Preserve renderer/CLI app/active, auth timing/OS properties, stop blocking/failures, reorder failures, and search outcomes. Add helper duration_ms to stop/reorder success and failure. Local OSS telemetry remains hard-disabled.

The draft bilingual Spec and Note document migration and semantics: cancel helper resolution is not turn-stop acknowledgment, and reorder resolution can include no-ops. Retired request events no longer provide a denominator for requests that never settle. Existing dashboards need event-name migration when their host adopts this change.

Visual explanation

Simple change: capture-call removal and result timing do not change control flow. The mapping below shows the entire event reduction.

Before / after

Before After
Auth readiness: active + auth_ready active, with the same readiness properties
Stop: request + helper result helper result + duration; blocked/failure retained
Reorder: request + helper result helper result + duration; failure retained
Search menu: request + conversation opened conversation opened

Test plan

  • Passed: 5 focused component suites, 80 tests (session-chat-search, workspace-machine-rpc-facade, posthog-analytics, posthog-provider, deferred-posthog).
  • Passed: pnpm format, component route generation (no generated diff), pnpm run docs check (existing warnings only), git diff --check, i18n, Code Collab import, platform-boundary and public-boundary checks.
  • pnpm check: typecheck and lint passed; stopped at the unchanged CLI github-git-transport.test.ts recursive SSH submodule test with context_unreadable. CLI totals: 3645 passed, 1 failed, 4 skipped. The same failure reproduces when running that file alone (5 passed, 1 failed). The remaining full test pipeline is not claimed green.
  • No production ingestion, dashboard configuration, or hosted rollout was tested.

Context handoff

Same-repository maintainer change. Public implementation evidence and limits are recorded in specs/auth-session-analytics.md and .agents/notes/implemented/simplification/2026-10-09-auth-session-analytics.md. No production raw events, private source, or transcripts are included. Hosted rollout and dashboard migration are outside this PR.

@Leeeon233
Leeeon233 marked this pull request as ready for review October 9, 2026 13:16
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Leeeon233
Leeeon233 merged commit db3bd73 into main Oct 9, 2026
13 checks passed
@Leeeon233
Leeeon233 deleted the chore/simplify-auth-session-analytics branch October 9, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant