Repository navigation
chore: consolidate auth and session operation analytics - #1360
Merged
Merged
Conversation
Model: gpt-6
Leeeon233
marked this pull request as ready for review
October 9, 2026 13:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Problem / pressure
The authenticated route emitted
app/activeandapp/auth_readyconsecutively with identical properties. Session controls also emitted request events before an existing result/open event. This is source-level redundancy; aggregate observations do not establish production duplication rates or prove failure is impossible.Summary
Remove
app/auth_ready,session/stop_requested,session/queue_item_reorder_requested, andsession/search_open_requested. Preserve renderer/CLIapp/active, auth timing/OS properties, stop blocking/failures, reorder failures, and search outcomes. Add helperduration_msto stop/reorder success and failure. Local OSS telemetry remains hard-disabled.The draft bilingual Spec and Note document migration and semantics: cancel helper resolution is not turn-stop acknowledgment, and reorder resolution can include no-ops. Retired request events no longer provide a denominator for requests that never settle. Existing dashboards need event-name migration when their host adopts this change.
Visual explanation
Simple change: capture-call removal and result timing do not change control flow. The mapping below shows the entire event reduction.
Before / after
Test plan
session-chat-search,workspace-machine-rpc-facade,posthog-analytics,posthog-provider,deferred-posthog).pnpm format, component route generation (no generated diff),pnpm run docs check(existing warnings only),git diff --check, i18n, Code Collab import, platform-boundary and public-boundary checks.pnpm check: typecheck and lint passed; stopped at the unchanged CLIgithub-git-transport.test.tsrecursive SSH submodule test withcontext_unreadable. CLI totals: 3645 passed, 1 failed, 4 skipped. The same failure reproduces when running that file alone (5 passed, 1 failed). The remaining full test pipeline is not claimed green.Context handoff
Same-repository maintainer change. Public implementation evidence and limits are recorded in
specs/auth-session-analytics.mdand.agents/notes/implemented/simplification/2026-10-09-auth-session-analytics.md. No production raw events, private source, or transcripts are included. Hosted rollout and dashboard migration are outside this PR.