Repository navigation
Add new default ellipse estimation method for beam mask using Sobel filter - #13
Merged
mgiammar merged 3 commits intoOct 28, 2026
Merged
Conversation
mgiammar
commented
Oct 20, 2026
mgiammar
commented
Member
- feat: beam mask estimation with Sobel edge fitting
- fix: low-pass filter cutoff correction
Contributor
|
Remove 3.10 from the CI to get the tests passing. |
Member
Author
|
No reason to keep otsu. There is no backwards compatibility issues other than the "method" field in the configuration becoming invalid. Nothing emitted as results are spesific to otsu. |
mgiammar
force-pushed
the
beam-mask-sobel-edge-fit
branch
from
October 21, 2026 00:26
d5fe48d to
e0def6e
Compare
The Sobel edge-ray fit replaces Otsu thresholding entirely. - Remove low_pass_filter, threshold_otsu and fit_ellipse from ripple.core.beam_mask, and the scikit-image dependency they needed. - BeamMaskConfig.threshold_method now only accepts "sobel"; the Otsu-only low_pass_resolution field is removed. - estimate_beam_mask drops its low_pass_resolution and device arguments. - BeamMaskResult.n_edge_points and n_inliers are now required ints. - BeamMaskResult.threshold_method is kept so downstream stores still get a value. - Manager tests use a Sobel-sized synthetic movie (8 A/px) instead of the 64x64 Otsu-only fixture. BREAKING CHANGE: configs that set threshold_method="otsu" or low_pass_resolution no longer validate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@jdickerson95 have removed the otsu paths, though this will make some configs/results incompatible with the newer version. Is ok since both un-released and in development. |
jdickerson95
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.