fix(cascade): land programmatic Node workflows on master - #16
Open
mateeullahmalik wants to merge 1 commit into
Open
fix(cascade): land programmatic Node workflows on master#16mateeullahmalik wants to merge 1 commit into
mateeullahmalik wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the already-reviewed sdk-js PR #15 Cascade changes on
master.PR #15 was merged into
chore/protos-v1.20.0shortly after PR #11 had already squash-merged that branch's earlier state intomaster. GitHub therefore marked #15 merged, but its 13-file runtime diff never reachedmaster.This PR is a clean cherry-pick of PR #15's implementation commit onto current
master. It excludes PR #11's generated-protobuf diff, which is already present onmaster.Behavior change
OfflineSigner/DirectSecp256k1HdWalletNode workflows.ACTION_STATE_DONEafter SuperNode upload completion.EventSourceis unavailable.Rationale
Without these changes, headless Node consumers can fail with
signArbitrary is not a function, creator-signature verification errors, premature upload success, protobuf metadata decode errors, or download monitoring failures.Scope integrity
master(bb3b68f)Verification
On this clean
masterparent:pnpm@10.28.1 install --frozen-lockfile— passedThe equivalent source tree also completed a real Lumera v1.20.2 testnet Cascade round-trip: 65,536-byte upload/download with SHA256 equality after on-chain finalization.
Risks
Rollback
Revert the single commit from this PR. Browser Keplr/Leap behavior and generated protobuf code are otherwise unchanged.
Migration / upgrade impact
Observability
No new external telemetry. Existing upload/download progress and thrown errors remain the operational signals.
Supersedes the missing-to-
masterdelivery of #15; it does not replace or alter #11.