Conversation
Due to Qt update (>=6.9.3), the workaround for the Windows ARM release notification crash is no longer needed.
Splits manifest loading into a parallel parse phase (file read + JSON parse) and a sequential apply phase (validation + inserting into available_layers), since the latter touches shared state. Added: - ParseLayerFile(): reads a manifest file and parses its JSON. No shared state, so safe to run on multiple threads at once. - ApplyParsedLayer(): takes already-parsed JSON, validates it, and inserts/updates it in available_layers. Kept sequential because it mutates shared data and depends on ordering. Removed: - LoadLayers(): did file read + parse + validate + insert all in one function, entirely sequentially. Replaced by the two functions above so the expensive I/O/parse part can run in parallel.
|
Author herlience not on autobuild list. Waiting for curator authorization before starting CI build. |
|
Author herlience not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2659
Splits manifest loading into a parallel parse phase (file read +
JSON parse) and a sequential apply phase (validation + inserting
into available_layers), since the latter touches shared state.
Added:
No shared state, so safe to run on multiple threads at once.
and inserts/updates it in available_layers. Kept sequential
because it mutates shared data and depends on ordering.
Removed:
in one function, entirely sequentially. Replaced by the two
functions above so the expensive I/O/parse part can run in
parallel.