Repository navigation
Calibration tests: fresh once-per-process store warnings for each test - #597
Merged
Merged
Conversation
The store and the profile reader warn once per message per process, so of two tests expecting the same warning in one worker, the second saw none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPvJBFJdUL6p1LDpss5
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The store and the profile reader in
solprop_nativewarn once per message per process. Two calibration tests expect the same "ignoring a calibration row"StoreWarning:test_a_malformed_row_is_passed_over(added in #582's last commit) andtest_an_unreadable_or_equal_row_is_replaced_on_publication. When xdist puts both in one worker, the second sees no warning and fails ("DID NOT WARN"). This happened on #582's last run (thelinux-x86_64-v2andwindows-amd64-v2lanes), which merged before the fix was pushed.main's CI passed on the merge only because the two tests ran in different workers.This adds
tests/calibration/conftest.pywith an autouse fixture that gives each calibration test fresh_WARNEDsets in both modules. Without it, running the two tests in one process fails; with it, they pass in either order, and so does the whole calibration suite.🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPvJBFJdUL6p1LDpss5