Repository navigation
Stop logging unhandled ComfyUI websocket messages at Warn - #1797
Merged
mohnjiles merged 2 commits intoNov 15, 2026
Merged
Conversation
Member
|
This commit doesn't depend on anything in #1796. It only touches Two small things while you're there:
|
HandleTextMessage only acts on executing, status, progress and execution_error. Every other message fell through to a Warn that included the full pretty-printed JSON payload, so normal ComfyUI traffic (execution_start, execution_cached, executed, execution_success, progress_state) and custom node broadcasts such as resource monitors that send a message every second filled app.log. Recognise the standard ComfyUI message types the client doesn't use and skip them silently, and log any other type at Trace with only its type. The full message is still available at Trace from the existing "Received json message" line. Invalid JSON is still logged at Warn.
… Debug Custom node message types all deserialize to Unknown, so read the type string from the message when logging it at Trace. Log execution_interrupted at Debug with its prompt and node ids, since it helps when diagnosing a generation that stopped.
deepratna-awale
force-pushed
the
quiet-comfy-websocket-logging
branch
from
November 11, 2026 20:33
ed9e80c to
8d5dbea
Compare
ionite34
approved these changes
Nov 14, 2026
mohnjiles
approved these changes
Nov 15, 2026
Member
|
The Build workflow hit a GitHub startup error before creating any jobs, and the retry is stuck queued. Briefly closing and reopening this PR to request a fresh Build run, then rechecking CLA as needed. No code changes or merge intended. |
Member
|
recheck |
mohnjiles
enabled auto-merge
November 15, 2026 03:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1796 for #1790. It addresses what is likely the main source of the log volume reported there.
ComfyClient.HandleTextMessageonly acts onexecuting,status,progressandexecution_error. Every other websocket message fell through to:That wrote the full pretty-printed JSON payload to
app.logat Warn, so no log level setting could hide it. This affected normal ComfyUI traffic (execution_start,execution_cached,executed,execution_success,progress_state) and custom-node broadcasts such as resource monitors that send a message every second.progress_statelists every node in the workflow, so one generation of a large workflow could add thousands of lines.Changes
ExecutionSuccess,ExecutionInterruptedandProgressStatetoComfyWebSocketResponseType.Received json messageline.HandleTextMessageis nowinternalso it can be tested (Core already hasInternalsVisibleTofor the test project).Testing
ComfyClientMessageLoggingTestscovers each standard type and a custom-node type logging nothing above Trace, the custom type logging its type without the payload, invalid JSON still warning, and the new enum values deserializing. On the previous code, 8 of these tests fail.app.log. After: none.PackageLinkTests(TestLicenseUrl/TestPreviewImageUri), which couldn't reach the internet in my test environment and are unrelated.