Repository navigation
Add missing CLIPLoader types and fp8_e4m3fn_fast weight dtype - #1801
Open
deepratna-awale wants to merge 1 commit into
Open
deepratna-awale wants to merge 1 commit into
deepratna-awale wants to merge 1 commit into
Conversation
Sync the Inference encoder type dropdown with ComfyUI's CLIPLoader options (krea2, ovis, longcat_image, flux3, ...) and offer the fp8_e4m3fn_fast UNETLoader weight dtype in the model cards. Fixes LykosAI#1786
deepratna-awale
marked this pull request as ready for review
November 19, 2026 01:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1786
Problem
The Inference Type dropdown in the Text Encoders section is a hardcoded list that has fallen behind ComfyUI's
CLIPLoader.krea2is missing, so Krea 2 models can only be run with a wrong encoder type and fail withKrea2 expects conditioning with 12x2560 features. The same goes for every other single-encoder type ComfyUI has added since the list was last updated.The model cards' Precision dropdown has the same problem: ComfyUI's
UNETLoaderoffersfp8_e4m3fn_fast, but only the Wan model card listed it.Changes
ModelCardViewModel.ClipTypes: added theCLIPLoadertypes that were missing compared to current ComfyUI:ovis,longcat_image,cogvideox,lens,pixeldit,ideogram4,boogu,krea2,joyimage,mage,minimax,yue2,flux3,moss_image,fibo2,pan2. TheDualCLIPLoadertypes were already complete.CLIPLoader/CLIPLoaderGGUFwithout further changes.ModelCardViewModel.WeightDTypesandUnetModelCardViewModel.WeightDTypes: addedfp8_e4m3fn_fast, matchingWanModelCardViewModeland ComfyUI'sUNETLoader.Screenshots
The Inference model card, rendered headless on main and on this branch with the same steps: UNet loader, Custom workflow, then
krea2picked as the encoder type andfp8_e4m3fn_fastas the precision.On main neither value is in its list, so both boxes stay empty.
Testing
ModelCardWorkflowProfileTests: the clip type list containskrea2and other new single-encoder types and has no duplicates, and the weight dtype list offersfp8_e4m3fn_fast.StabilityMatrix.Tests: all passed except theTestLicenseUrl/TestPreviewImageUrichecks, which need outbound network access that my test environment blocks (unrelated to this change).