Repository navigation
Create MAAP client lazily in stage_in - #11
Merged
Merged
Conversation
Avoids the /api/environment/config call at import time for jobs with no file inputs (fixes #10). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XHifpuJ7Q83CrNkchsbuRj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
stage_in.pybuiltMAAP()at import, so every job (viacreate_inputs.py'simport stage_in) called/api/environment/configeven with no file inputs.maap = MAAP()with a cached_get_maap(), called only in_download_assetfor non-s3://maap-URLs.tests/test_stage_in.pyto patchstage_in._get_maap; add tests that no client is created for MAAP S3 downloads and that it's created once on demand.Tests: 39 pass in
tests/test_stage_in.py;test_stac_extensions_preservedandtest_self_href_set_to_local_pathfail identically on the base branch (pre-existing, unrelated).🤖 Generated with Claude Code
https://claude.ai/code/session_01XHifpuJ7Q83CrNkchsbuRj
Generated by Claude Code