streaming (incremental) MESSI - #74
Merged
Merged
Conversation
MChatzakis
requested changes
Sep 16, 2026
MChatzakis
left a comment
MChatzakis
left a comment
Owner
There was a problem hiding this comment.
Minor fixes, looks good otherwise
|
|
||
| daisy::idx_t *indices = new daisy::idx_t[n_query * k]; | ||
| float *distances = new float[n_query * k]; | ||
| search.searchIndex(query, n_query, k, indices, distances); |
Owner
There was a problem hiding this comment.
Would be nice to include an intermediate search call in-between the data addition.
| std::vector<std::vector<idx_t>> &I, | ||
| std::vector<std::vector<float>> &D) | ||
| { | ||
| activateBreakpoints(); |
Owner
There was a problem hiding this comment.
Why did this return to the searchIndex functions?
| range.r = 1e-5f; | ||
| std::vector<std::vector<daisy::idx_t>> indices; | ||
| std::vector<std::vector<float>> distances; | ||
| search.searchIndex(all.data() + 7 * DIM, 1, range, indices, distances); |
Owner
There was a problem hiding this comment.
I think it would be nice to have an intermediate search call in the tests as well
MChatzakis
approved these changes
Sep 17, 2026
MChatzakis
left a comment
MChatzakis
left a comment
Owner
There was a problem hiding this comment.
We still have some activate breakpoint calls inside the search but it is okay for now. If you have time in the future, try to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.