Repository navigation
feat(messages): add slide notices which scroll across the top of the screen - #1241
Merged
Merged
Conversation
…screen Since season 1, the client scrolls 0x0D notices of the types 10 to 15 through the help and notice bands at the top of the screen, but OpenMU only sent the types 0 to 2. The new SlideNotice packet defines the fields the client reads for them (loop count, loop delay, color, speed). MessageType.SlideNotice is sent as SlideNotice packet of type 14 (queued in the notice band, shown once). Clients before season 1 get a golden notice instead. It can be sent with the new GM command '/slidenotice <text>' and from the admin panel, whose global message now has a message type selector. Split out of #995; the packet is now defined in the XML instead of being written by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uz47mrsSwm3hxZc7gCMxd9
Deploying openmudocs with
|
| Latest commit: |
bec89d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2158f1d9.openmudocs.pages.dev |
| Branch Preview URL: | https://claude-pr995-slide-notice.openmudocs.pages.dev |
This was referenced Oct 17, 2026
…ction Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uz47mrsSwm3hxZc7gCMxd9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #995 (original feature by Diego Amatte), reworked to define the packet in the XML instead of writing it by hand.
What it does
Since season 1, the client has two bands at the top of the screen through which it scrolls
0x0Dnotices of the types 10 to 15. OpenMU only sent the types 0–2 (golden, blue, guild notice). This PR adds:MessageType.SlideNotice(appended as value3; the existing values are unchanged).A new
SlideNoticepacket (C1 0D) inServerToClientPackets.xml, with the fields the client reads for these types:0xAABBGGRRThe generated structs,
SendSlideNoticeAsync, the packet tests anddocs/Packetsare regenerated from the XML (rule 2).ShowMessagePlugInsendsSlideNoticeas type 14: queued in the notice band, shown once, white, default speed. Clients before season 1 don't have the bands or these fields (that's also why they don't get the000000000prefix), so they get a golden notice instead.New GM chat command
/slidenotice <text>(same shape as/goldnotice, fresh GUID, resource-based name and description).The global message card of the admin panel's Servers page gets a message type selector (golden / blue / slide). The docs page
admin-panel/servers.mdis updated.Client behaviour
The packet layout and type semantics come from the open source client (
ReceiveNotice/CSlideHelpMgr::AddSlide/CUISlideHelp::AddSlidein MuMain).PRECEIVE_NOTICEisn't packed, soDelayis at offset 6,Colorat 8,Speedat 12 and the text at 13. Within a band, the first type drops a message that couldn't be shown within a minute, the second queues it, and the third puts it at the front of the queue.Testing
ShowMessagePlugInTests: a season 6 client gets aSlideNoticepacket with the expected field values; a 0.75 client gets a goldenServerMessage.-demomode): the Servers page shows the message type selector (Golden / Blue / Slide), and sending a slide message to all game servers works without errors. No game client was connected, so the scrolling itself wasn't seen in game; the packet layout above was checked against the client source.Generated by Claude Code