Repository navigation
feat(localization): support localized cash shop package names - #1252
Merged
sven-n merged 1 commit intoOct 19, 2026
Merged
Conversation
Member
|
Review: looks good, and it follows the existing Verified locally (head
Notes:
Ready to merge from my side. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cash shop package names are currently plain strings, so the catalog cannot display/edit translations or use the Configuration names workflow. This change makes them resource-backed
LocalizedStringvalues, with 203 Simplified Chinese resource entries covering the 205 built-in Season 6 packages. Catalog display, search and editing use the existing localization components; search also accepts the neutral name.Closes #1250. The separate admin interface translations are in #1251; neither PR depends on the other.
Existing catalogs use the existing link/review/apply workflow. The fallback matches package script numbers only when unique on both sides and requires exact neutral text. Custom neutral names and translations are preserved, and repeated linking/applying is idempotent. Resource sources are registered through
ConfigurationNameSources; no batch-specific update plugin or custom resource loader is added.All 205 neutral names and all catalog parameters were compared with master and are unchanged. The existing
textcolumn reads old plain names throughLocalizedStringConverter;dotnet ef migrations has-pending-model-changesreports no changes, so no empty migration is included. Client scripts and gameplay are unaffected. The operator documentation explains the workflow and distinguishes sourced Chinese terminology from descriptive translations.Validation on current master with .NET 10:
GenerateResource(StronglyTypedResourceBuilder), the EF compiled entity withdotnet ef dbcontext optimize, and the configuration loader with its generator test. No unrelated generated files are included.Reviewed against the feedback in #981, #1014, #1071, #1124 and #1182: neutral comparisons use
ValueInNeutralLanguage, UI text resolves explicitly, resources use descriptive keys, and the tests do not require future neutral entries to have Chinese translations.