Repository navigation
Conversation
A live window-resize of a vertical list only changes the content WIDTH: every item Top stays valid, yet DoRealign repositioned all items - on a 24k-item list that is ~100ms of SetBounds per WM_SIZE, freezing the resize. TMainContent.SizeChanged now detects the width-only case and resizes just the visible/preloaded window; the remaining items get their width lazily in FetchContent (EnsureItemWidth, under FDisableAlign so the item SizeChanged cannot cascade into a realign), right before the content builder captures the item bounds. A full DoRealign(0) clears the lazy flag again. Also completes the preloaded-window bookkeeping from MagicFoundation#519 for the insert side: inserting inside the window no longer extends it across the inserted (never prepared) items - the shifted prepared tail is unprepared and the window is clamped to the part before the insertion point, mirroring the DeleteItems bookkeeping. This also keeps the width-only pass bounded to the real window. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live window-resize of a vertical list only changes the content WIDTH: every item Top stays valid, yet DoRealign repositioned all items - on a 24k-item list that is ~100ms of SetBounds per WM_SIZE, freezing the resize. TMainContent.SizeChanged now detects the width-only case and resizes just the visible/preloaded window; the remaining items get their width lazily in FetchContent (EnsureItemWidth, under FDisableAlign so the item SizeChanged cannot cascade into a realign), right before the content builder captures the item bounds. A full DoRealign(0) clears the lazy flag again.
Also completes the preloaded-window bookkeeping from #519 for the insert side: inserting inside the window no longer extends it across the inserted (never prepared) items - the shifted prepared tail is unprepared and the window is clamped to the part before the insertion point, mirroring the DeleteItems bookkeeping. This also keeps the width-only pass bounded to the real window.