Fix uncalibrated image conversion - #64
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Use the final valid scan index (NumScans - 1) when calculating the slope.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes uncalibrated image conversion by updating scan-index and ion-mobility calculations.
Changes:
- Uses direct linear interpolation from raw IM boundaries.
- Updates forward and reverse conversion formulas.
- Removes unnecessary square-root and squaring operations.
File summaries
| File | Review |
|---|---|
crates/timsrust-tdf/src/calibration.rs |
Conversion formulas updated, but scan_max_index uses the scan count instead of the final valid index, causing an endpoint mapping error. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sander-willems-bruker
marked this pull request as ready for review
September 11, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the im conversion logic to correctly calculate the intercept and slope, ensuring accurate conversion between scan indices and im values.