Skip to content

Feat/postgres adoption - #25

Merged
Makisuo merged 12 commits into
mainfrom
feat/postgres-adoption
Oct 9, 2026
Merged

Makisuo merged 12 commits into
mainfrom
feat/postgres-adoption

Conversation

@Makisuo

@Makisuo Makisuo commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Makisuo added 12 commits October 9, 2026 18:59
…every column

PG.column(type, { name }) stores a column under a database name while
queries, inserts, updates and rows use its key, as drizzle's
text("org_id") does. A bare select() reads every column of the table.
Plain values compared with a column typed as a string literal union must
be members of it; params and expressions of the primitive still compare.
Also covers timestamptzMillis in the Postgres manifest and documents
column names, select() and timestamptzMillis.
… statement

On a dialect that binds params, a value compared with a column and a
LIKE pattern become params, one per distinct value, so statement text
carries no values. An ON CONFLICT index predicate and DDL stay literal.
like/ilike/notLike also take a param or expression.
A folder another tool applies (drizzle-kit, alchemy, Neon) only reads
migration.sql, so a generated migration.json would be skipped there.
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 780b139e-204e-409c-b9af-91bcb4ba554f

📥 Commits

Reviewing files that changed from the base of the PR and between 146929a and 76be255.


⛔ Files ignored due to path filters (1)
  • tests/__snapshots__/core-sql.test.ts.snap is excluded by !**/*.snap

📒 Files selected for processing (33)
  • docs/extending.md
  • docs/migrations.md
  • docs/postgres.md
  • docs/queries.md
  • docs/reference.md
  • docs/tables-and-types.md
  • package.json
  • scripts/check-doc-examples.mjs
  • src/ch/brand.test-d.ts
  • src/ch/compile.ts
  • src/ch/dialect.test.ts
  • src/ch/expr.ts
  • src/ch/insert.test.ts
  • src/ch/literal.ts
  • src/ch/predicates.test.ts
  • src/ch/query.ts
  • src/ch/sql-template.test.ts
  • src/ch/sql-template.ts
  • src/ch/types.ts
  • src/ch/update.test.ts
  • src/core.ts
  • src/kit/generate.ts
  • src/kit/kit.test.ts
  • src/pg/bound-literals.test.ts
  • src/pg/column-names.test.ts
  • src/pg/functions.ts
  • src/pg/postgres.test.ts
  • src/pg/timestamptz-millis.test.ts
  • src/pg/types.ts
  • src/schema/define.ts
  • src/schema/pg-define.ts
  • src/sql/literal-binder.ts
  • tests/dialect-cases.postgres.ts

 __________________________________________________________
< If your code was a carrot, I'd bury it and forget where. >
 ----------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Makisuo
Makisuo merged commit 7b947d1 into main Oct 9, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant