Skip to content

feat(web): Google Cloud integration card - #1334

Open
JeremyFunk wants to merge 63 commits into
feat/gcp-metrics-pollerfrom
feat/gcp-integration-card
Open

JeremyFunk wants to merge 63 commits into
feat/gcp-metrics-pollerfrom
feat/gcp-integration-card

style(web): format the Google Cloud confirmation

4c4caf6
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 16, 2026 in 47s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
Only the confirmation copy changed since the last review; the fix names both capabilities and I read all 1859 lines of the dialog.
quality 98/100 · 1 note · tests partial · risk medium

The confirmation in the Google Cloud configure dialog now names both capabilities when one save turns one off and the other back on. The fix is correct and the changed file adds no new defect; the earlier info-level test gap for the script's rr-block guard is still open.

  • ChooseStage builds turned from stopping and resuming, so the dialog names both flips
  • confirmLabel reads Save and continue when a save both stops and resumes

Still open from earlier reviews

Fixed since the last review

  • ✅ F3 · Confirmation names only the capability turned off while the save also turns one back on
What was checked
  • turned and confirmLabel cover stop-only, resume-only and both flips (gcp-configure.tsx:1024-1039, :1114-1120)
  • A save still sends only the flipped flags when one capability changed (gcp-configure.tsx:1047-1051)
  • Ran git diff 4db40c0..4c4caf6 on the file: the confirmation block is the only change

4c4caf6 · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.