Skip to content

feat(infra): Infrastructure → Google Cloud page - #1336

Merged
JeremyFunk merged 101 commits into
feat/gcp-dashboard-templatefrom
feat/gcp-infra-page
Oct 16, 2026
Merged

feat(infra): Infrastructure → Google Cloud page#1336
JeremyFunk merged 101 commits into
feat/gcp-dashboard-templatefrom
feat/gcp-infra-page

Merge feat/gcp-dashboard-template into feat/gcp-infra-page

c11e47c
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 16, 2026 in 2m 29s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
The delta since the last review is main-side merges already on the base branch plus the nav row and preview fix, which the unit tests pin.
quality 100/100 · no findings · tests covered · risk medium · 2/2 new units observable

Delta since the last review: main-side merges (#1511, #1514) already on the base branch, plus the Google Cloud nav row and the sidebar preview fix, both pinned by unit tests. Safe to merge; the two open errors (registry.ts, warehouse-query-atoms.ts) are untouched.

  • nav-items.ts adds the Google Cloud child gated on the gcp surface
  • NavRow drops the section's own front door (Overview) from the glyph preview
  • ci.yml adds packages/query-engine-integrations/** to the ClickHouse sweep filter

Before merge

  • Manual · Merge the stack bottom-up: feat/gcp-dashboard-template (#1336's base) before this branch

Production impact

Open errors in the changed files
Issue Service Occurrences File
@maple/mcp/errors/McpQueryError maple-chat 15 apps/web/src/lab/registry.ts
@maple/web/errors/WarehouseInvalidInputError maple-web 9 apps/web/src/lib/services/atoms/warehouse-query-atoms.ts

After this merges, Maple checks whether they stop.

Production traffic of the changed files (last 7 days)
File Calls/day Busiest operations
packages/domain/src/http/integrations.ts 209 GET /v2/integrations/gcp 209/day, 0.0% err
apps/web/src/api/warehouse/gcp-infra.ts 143 QueryEngine.getGcpInfraMetrics 28/day, 0.0% err
gcpInfraMetrics 28/day, 0.5% err
QueryEngine.getGcpInfraPresence 12/day, 0.0% err
apps/api/src/routes/internal/query-engine.http.ts 76 gcpInfraMetrics 28/day, 0.5% err
gcpInfraPresence 12/day, 0.0% err
gcpInfraSparklines 11/day, 0.0% err
packages/domain/src/http/query-engine.ts 76 gcpInfraMetrics 28/day, 0.5% err
gcpInfraPresence 12/day, 0.0% err
gcpInfraSparklines 11/day, 0.0% err
apps/api/src/routes/queries.ts 67 gcpInfraMetrics 28/day, 0.5% err
gcpInfraPresence 12/day, 0.0% err
gcpInfraSparklines 11/day, 0.0% err
packages/backend/src/services/integrations/GcpConnectorService.ts 18 GcpConnectorService.resources 15/day, 0.0% err
GcpConnectorService.scripts 3/day, 0.0% err
Telemetry this change adds and removes (1)
  • ➕ span name QueryEngine.getGcpCloudSqlInstancesOfDatabase · apps/web/src/api/warehouse/gcp-infra.ts:183
What was checked
  • Infrastructure has 7 children; the preview cap still holds at the 6 sources (nav-items.ts:141, app-sidebar.tsx:306)
  • Explore's parent href equals its Traces child, but its children carry no iconColor, so the new skip cannot reach it (app-sidebar.tsx:301)
  • use-infra-surfaces.ts:104 adds gcp when a connector has metrics_enabled, so the new row's gate is satisfiable
Observability coverage: 2 of 2 changes observable
Change Kind Observable Evidence
Google Cloud infra warehouse queries (gcpInfraMetrics, gcpInfraPresence, gcpInfraSparklines) database read yes telemetry: maple-web spans of those names, 28/12/11 calls per day
GcpConnectorService.resources / .scripts (GCP connector reads) outbound GCP API call yes telemetry: maple-api spans GcpConnectorService.resources (15/day), .scripts (3/day)

c11e47c · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot