Repository navigation
feat(integrations): plain, scannable Google Cloud integration page - #1481
Closed
JeremyFunk wants to merge 8 commits into
Closed
JeremyFunk wants to merge 8 commits into
JeremyFunk wants to merge 8 commits into
Maple Review Bot / Maple / review
succeeded
Oct 15, 2026 in 2m 50s
Confidence 8/10 · No issues found
🟢 Confidence 8/10 · likely safe to merge
Presentation-only diff, read in full; the one open item is the pre-existing duplicated state-to-tone mapping at gcp-integration-card.tsx:612.
quality 98/100 · 1 note · tests not needed · risk low
Rework of the Google Cloud integration page and its configure dialog into a plainer, sans-for-prose layout: a header state and facts row, logs and metrics always side by side, and a standard warn alert for the run-the-script prompt. No functional change found; the earlier duplicated state-to-tone mapping is still present.
GcpHeaderStatus/GcpHeaderFactsadd a state line and facts row to the integrations headerCapabilityfolds its link into the·-joined facts lineAttentionrenders a warnAlertwith anAlertActioninstead of a tinted boxGcpConnectiondrops the per-connection state badge and the hint-based stacking of logs and metrics
Still open from earlier reviews
- 🔵 Note · F1 · Header repeats the hub row's state-to-tone mapping at line 586 ·
apps/web/src/components/integrations/gcp-integration-card.tsx:612
What was checked
gcpWorstStatefalls back tohealthyfor no connections (gcp-connector-state.ts:274), soGCP_CONNECTION_LABEL[worst]at :613 is always a stringAlertspreads props afterrole="alert"(packages/ui/src/components/ui/alert.tsx:37), so the run-the-script alert'srole="status"winsFILTER_TEXTis total overGcpLogFilterviasatisfies, soFILTER_TEXT[choice.selected]at gcp-configure.tsx:657 cannot be undefined
104a4aa · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading