Skip to content

feat(integrations): plain, scannable Google Cloud integration page - #1481

Closed
JeremyFunk wants to merge 8 commits into
feat/gcp-dashboard-templatefrom
feat/gcp-integration-page-plain
Closed

JeremyFunk wants to merge 8 commits into
feat/gcp-dashboard-templatefrom
feat/gcp-integration-page-plain

Merge remote-tracking branch 'origin/feat/gcp-dashboard-template' int…

104a4aa
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 15, 2026 in 2m 50s

Confidence 8/10 · No issues found

🟢 Confidence 8/10 · likely safe to merge
Presentation-only diff, read in full; the one open item is the pre-existing duplicated state-to-tone mapping at gcp-integration-card.tsx:612.
quality 98/100 · 1 note · tests not needed · risk low

Rework of the Google Cloud integration page and its configure dialog into a plainer, sans-for-prose layout: a header state and facts row, logs and metrics always side by side, and a standard warn alert for the run-the-script prompt. No functional change found; the earlier duplicated state-to-tone mapping is still present.

  • GcpHeaderStatus/GcpHeaderFacts add a state line and facts row to the integrations header
  • Capability folds its link into the ·-joined facts line
  • Attention renders a warn Alert with an AlertAction instead of a tinted box
  • GcpConnection drops the per-connection state badge and the hint-based stacking of logs and metrics

Still open from earlier reviews

What was checked
  • gcpWorstState falls back to healthy for no connections (gcp-connector-state.ts:274), so GCP_CONNECTION_LABEL[worst] at :613 is always a string
  • Alert spreads props after role="alert" (packages/ui/src/components/ui/alert.tsx:37), so the run-the-script alert's role="status" wins
  • FILTER_TEXT is total over GcpLogFilter via satisfies, so FILTER_TEXT[choice.selected] at gcp-configure.tsx:657 cannot be undefined

104a4aa · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.