Repository navigation
fix(errors): keep location-less Effect span frames out of the fingerprint - #1493
Merged
Makisuo merged 3 commits intoOct 15, 2026
Merged
Maple Review Bot / Maple / review
succeeded
Oct 15, 2026 in 47s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge
Only new hunk is a test layer-wiring refactor; the assertions it drives are unchanged and the merged layer type is unaffected.
quality 100/100 · no findings · tests covered · risk low
The delta since the previous review is a test-only refactor: Telemetry.test.ts now builds the telemetry layer inside the ingest layer with Layer.provideMerge instead of providing them separately. Nothing production-side changed; safe to merge.
Telemetry.test.tsprovides ingest and telemetry through oneLayer.provideMerge
Before merge
- Migration · Check it is safe on production data and with the code still deployed ·
packages/domain/src/clickhouse/migrations/0040_error_fingerprint_span_name_frames.ts
What was checked
SPAN_NAME_FRAME_PATTERNrun against 10 frame shapes in node: dropsat POST/at http.client POST, keepsat file:///app/a.js:1:2and paren framestelemetryLayerreturnsLayer.Layer<never>, so theprovideMergeoutput staysOtlpIngestand the shutdown flush still runs after ingest closes
b796a0e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading