Skip to content

fix(errors): keep location-less Effect span frames out of the fingerprint - #1493

Merged
Makisuo merged 3 commits into
claude/elegant-kare-c2b94dfrom
claude/suspicious-merkle-c8b324
Oct 15, 2026
Merged

Makisuo merged 3 commits into
claude/elegant-kare-c2b94dfrom
claude/suspicious-merkle-c8b324

Merge claude/elegant-kare-c2b94d into claude/suspicious-merkle-c8b324

b796a0e
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 15, 2026 in 47s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge
Only new hunk is a test layer-wiring refactor; the assertions it drives are unchanged and the merged layer type is unaffected.
quality 100/100 · no findings · tests covered · risk low

The delta since the previous review is a test-only refactor: Telemetry.test.ts now builds the telemetry layer inside the ingest layer with Layer.provideMerge instead of providing them separately. Nothing production-side changed; safe to merge.

  • Telemetry.test.ts provides ingest and telemetry through one Layer.provideMerge

Before merge

What was checked
  • SPAN_NAME_FRAME_PATTERN run against 10 frame shapes in node: drops at POST/at http.client POST, keeps at file:///app/a.js:1:2 and paren frames
  • telemetryLayer returns Layer.Layer<never>, so the provideMerge output stays OtlpIngest and the shutdown flush still runs after ingest closes

b796a0e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.