Skip to content

Add remaining read-only physical coverage - #34

Merged
MarcLeinenDE merged 1 commit into
mainfrom
test/remaining-readonly-coverage
Sep 25, 2026
Merged

MarcLeinenDE merged 1 commit into
mainfrom
test/remaining-readonly-coverage

Conversation

@MarcLeinenDE

@MarcLeinenDE MarcLeinenDE commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Add a dedicated physical SDK suite for seven existing read-only helpers that were still missing persisted physical coverage in the canonical API↔SDK audit.

Covered without logging sensitive values:

  • router/get_mac_info
  • statistics/get_login_client_mac
  • version/get_magicnumber
  • wireless/get_diag_wifi_info
  • wireless/get_extender_config
  • wireless/wifi_get_timed_off_status
  • sms/sms.query

API-first check:

  • all seven contracts are already LIVE_VERIFIED, ADMIN_OK and READ_OR_LOW_SIDE_EFFECT on current nr2301-api/main
  • no upstream contract change is required before this SDK test branch
  • any new physical mismatch found by the run will be normalized in nr2301-api first before this PR is merged

Privacy:

  • no MAC values, SSIDs, extender keys, magic value or SMS IDs are printed
  • SMS query logs only resp or count, never IDs

Keep draft until the physical router run completes.

Physical run (2026-09-25):

  • 7/7 tests passed in 0.86s
  • router/get_mac_info: PASS without logging identifiers
  • statistics/get_login_client_mac: PASS without logging identifier
  • version/get_magicnumber: PASS without logging raw value
  • wireless/get_diag_wifi_info: PASS
  • wireless/get_extender_config: PASS without logging SSID/key values
  • wireless/wifi_get_timed_off_status: PASS
  • sms/sms.query: PASS through endpoint-specific semantic non-success handling with resp=-2; no SMS IDs logged
  • canonical API evidence/audit was updated first in nr2301-api PR Add remaining read-only physical coverage #34, merged as 38c7331a54dcdfb4739108f6cd439b391e5ecf92
  • API validator #216: SUCCESS

This closes all seven read-only existing-helper gaps targeted by this PR.

@MarcLeinenDE
MarcLeinenDE marked this pull request as ready for review September 25, 2026 06:54
@MarcLeinenDE
MarcLeinenDE merged commit 739ea88 into main Sep 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant