Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regenerate and commit both tracked distributable bundles so installed users receive the new table functionality.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds read-only, themed, sanitized Markdown table rendering to hidden syntax mode, with widget behavior and test coverage.
Changes:
- Adds table parsing, rendering, styling, and CodeMirror widgets.
- Adds DOMPurify dependency and lockfile updates.
- Adds renderer and widget tests.
- Committed distributable bundles still require regeneration.
File summaries
| File | Summary |
|---|---|
yarn.lock |
Updates dependency lock data. |
tests/render.test.ts |
Tests table rendering. |
tests/hiddenSyntax/table.test.ts |
Tests table widget behavior. |
src/styling.ts |
Adds editor theme CSS. |
src/render.ts |
Renders table blocks. |
src/hiddenSyntax/theme.ts |
Styles hidden table widgets. |
src/hiddenSyntax/index.ts |
Enables block decorations. |
src/hiddenSyntax/components/table.ts |
Implements read-only table widgets. |
src/hiddenSyntax/block.ts |
Integrates table decorations and lifecycle. |
package.json |
Adds DOMPurify dependency. |
Review details
- Files reviewed: 9/12 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Rebuild and commit the shipped dist bundles so table support reaches users.
Review details
Suppressed comments (1)
src/hiddenSyntax/index.ts:60
- This enables table rendering in the source extension, but the repository's committed
dist/markedit-preview.jsanddist/lite/markedit-preview.jsare not updated in this PR. Those are the shipped/generated bundles, so users installing the extension will not receive the table support (and the new DOMPurify dependency) until both bundles are rebuilt and committed.
renderedBlockDecorations,
- Files reviewed: 10/13 changed files
- Comments generated: 0 new
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #188 (comment)