Skip to content

Improve table layout in preview mode - #193

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Sep 18, 2026
Merged

cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new display: table combined with overflow: auto can break horizontal scrolling for wide tables due to inconsistent overflow behavior on table display types.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR adjusts the GitHub theme’s table styling to change how tables size and constrain their width in preview mode, and regenerates the shipped bundles accordingly.

Changes:

  • Update .markdown-body table to use display: table, width: auto, and a capped max-width.
  • Regenerate the full and lite distribution bundles to include the updated CSS.
File summaries
File Description
styles/themes/github/base.css Changes the core GitHub theme table layout rules used by the preview.
dist/markedit-preview.js Regenerated full bundle reflecting the theme CSS change.
dist/lite/markedit-preview.js Regenerated lite bundle reflecting the theme CSS change.
Review details
  • Files reviewed: 1/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread styles/themes/github/base.css Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new CSS uses fit-content and min() without fallbacks, which can regress behavior on hosts that don’t support those constructs unless compatibility fallbacks are added and bundles are regenerated.

Get a fresh assessment by requesting another Copilot review.

Review details
  • Files reviewed: 1/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread styles/themes/github/base.css

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, consistent with existing CSS feature usage in this theme, and the generated dist artifacts were updated accordingly.

Review details
  • Files reviewed: 1/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@cyanzhong
cyanzhong merged commit 19c2931 into main Sep 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants