Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Regenerate and commit the distributed bundles so they match the updated source behavior.
Pull request overview
Migrates inline image configuration to the typed inlineRendering setting while preserving deprecated inlineImages compatibility.
Changes:
- Adds rendering settings validation and migration.
- Applies configuration to images, tables, math, and Mermaid blocks.
- Updates tests and documentation.
File summaries
| File | Summary |
|---|---|
tests/settings.test.ts |
Tests settings compatibility and validation. |
tests/hiddenSyntax/link.test.ts |
Updates image rendering coverage. |
tests/hiddenSyntax/block.test.ts |
Tests rendering options and reconfiguration. |
src/support/settings.ts |
Defines and resolves rendering settings. |
src/hiddenSyntax/index.ts |
Applies configured image rendering. |
src/hiddenSyntax/config.ts |
Adds rendering configuration support. |
src/hiddenSyntax/block.ts |
Applies configured block rendering. |
README.md |
Documents the new and deprecated settings. |
Review details
Suppressed comments (1)
src/support/settings.ts:32
- This runtime change also needs the committed
dist/markedit-preview.jsanddist/lite/markedit-preview.jsbundles regenerated; otherwise installed users continue executing the old boolean-only setting logic even though the source and README advertiseinlineRendering. Please include the build outputs (or otherwise update the release/build process so these checked-in artifacts are synchronized).
export const inlineRendering: readonly InlineRenderingType[] = Array.isArray(rootValue.inlineRendering)
? rootValue.inlineRendering.filter((value): value is InlineRenderingType =>
value === 'image' || value === 'table' || value === 'math' || value === 'mermaid')
: inlineImages ? ['image', 'table', 'math', 'mermaid'] : ['table', 'math', 'mermaid'];
- Files reviewed: 8/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.