Skip to content

Migrate inlineImages to inlineRendering - #195

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Sep 18, 2026
Merged

cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Regenerate and commit the distributed bundles so they match the updated source behavior.

Pull request overview

Migrates inline image configuration to the typed inlineRendering setting while preserving deprecated inlineImages compatibility.

Changes:

  • Adds rendering settings validation and migration.
  • Applies configuration to images, tables, math, and Mermaid blocks.
  • Updates tests and documentation.
File summaries
File Summary
tests/settings.test.ts Tests settings compatibility and validation.
tests/hiddenSyntax/link.test.ts Updates image rendering coverage.
tests/hiddenSyntax/block.test.ts Tests rendering options and reconfiguration.
src/support/settings.ts Defines and resolves rendering settings.
src/hiddenSyntax/index.ts Applies configured image rendering.
src/hiddenSyntax/config.ts Adds rendering configuration support.
src/hiddenSyntax/block.ts Applies configured block rendering.
README.md Documents the new and deprecated settings.
Review details

Suppressed comments (1)

src/support/settings.ts:32

  • This runtime change also needs the committed dist/markedit-preview.js and dist/lite/markedit-preview.js bundles regenerated; otherwise installed users continue executing the old boolean-only setting logic even though the source and README advertise inlineRendering. Please include the build outputs (or otherwise update the release/build process so these checked-in artifacts are synchronized).
export const inlineRendering: readonly InlineRenderingType[] = Array.isArray(rootValue.inlineRendering)
  ? rootValue.inlineRendering.filter((value): value is InlineRenderingType =>
    value === 'image' || value === 'table' || value === 'math' || value === 'mermaid')
  : inlineImages ? ['image', 'table', 'math', 'mermaid'] : ['table', 'math', 'mermaid'];
  • Files reviewed: 8/10 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cyanzhong
cyanzhong merged commit 745beb0 into main Sep 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants