Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The blank-line exception bypasses folded-table behavior and must be guarded by the existing fold check.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates hidden table handling so table source remains visible when the caret is on the blank line immediately after a table.
Changes:
- Added blank-line caret and row-editing tests.
- Updated table visibility handling.
- Regenerated full and lite bundles.
File summaries
| File | Summary |
|---|---|
tests/hiddenSyntax/table.test.ts |
Added coverage for blank-line caret behavior. |
src/hiddenSyntax/block.ts |
Moderate issue: the exception can reveal explicitly folded tables; apply it only when !folded. |
dist/markedit-preview.js |
Regenerated full bundle. |
dist/lite/markedit-preview.js |
Regenerated lite bundle. |
Review details
- Files reviewed: 2/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.