Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor, non-blocking swatch-width nit remains.
Pull request overview
Redesigns built-in theme picker swatches with pill-shaped backgrounds, circular color indicators, and updated palettes.
Changes:
- Updates swatch rendering and sizing.
- Adjusts dark-theme presentation.
- Expands built-in theme palettes.
File summaries
| File | Summary |
|---|---|
MarkEditMac/Sources/Main/AppTheme.swift |
Updates swatch rendering and theme palettes. |
Review details
Suppressed comments (1)
MarkEditMac/Sources/Main/AppTheme.swift:46
- The drawing handler paints the pill only through
backgroundRect, whose width issize.width, but the image is allocated 4 points wider. This leaves a transparent strip on the right of every picker swatch and makes the visible pill asymmetrically padded; allocate the image atsizeunless that extra margin is also drawn intentionally.
return NSImage(size: CGSize(width: size.width + 4, height: size.height), flipped: false) { _ in
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.