Skip to content

Redesign color swatch in theme picker - #1741

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Sep 13, 2026
Merged

cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a minor, non-blocking swatch-width nit remains.

Pull request overview

Redesigns built-in theme picker swatches with pill-shaped backgrounds, circular color indicators, and updated palettes.

Changes:

  • Updates swatch rendering and sizing.
  • Adjusts dark-theme presentation.
  • Expands built-in theme palettes.
File summaries
File Summary
MarkEditMac/Sources/Main/AppTheme.swift Updates swatch rendering and theme palettes.
Review details

Suppressed comments (1)

MarkEditMac/Sources/Main/AppTheme.swift:46

  • The drawing handler paints the pill only through backgroundRect, whose width is size.width, but the image is allocated 4 points wider. This leaves a transparent strip on the right of every picker swatch and makes the visible pill asymmetrically padded; allocate the image at size unless that extra margin is also drawn intentionally.
    return NSImage(size: CGSize(width: size.width + 4, height: size.height), flipped: false) { _ in
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cyanzhong
cyanzhong merged commit 734c199 into main Sep 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants