Repository navigation
fix: ship font and image assets with the package builds - #192
Merged
Merged
Conversation
esbuild emitted fonts and images as build/<asset>-<hash>.*, but distributeBuildFiles.js only copies files starting with the package name, so the published packages referenced a missing fa-solid-900 font and the Leaflet images. Prefix assets with the package name so they are shipped, and copy them into the Docker image as well. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KyMfexu5WafYRCzh4jhKu6
MathiasVDA
marked this pull request as ready for review
October 6, 2026 12:11
Closed
MathiasVDA
added a commit
that referenced
this pull request
Oct 11, 2026
…192) esbuild emitted fonts and images as build/<asset>-<hash>.*, but distributeBuildFiles.js only copies files starting with the package name, so the published packages referenced a missing fa-solid-900 font and the Leaflet images. Prefix assets with the package name so they are shipped, and copy them into the Docker image as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Before: loading
@matdata/yasguifrom unpkg/jsdelivr (or the Docker image) shows no icons.yasgui.min.cssreferences./fa-solid-900-XY6737PV.woff2and the Leaflet map images, but those files are not in the published package, so they return 404.After: the font and image files ship next to the CSS in each package (
yasgui,yasqe,yasr) and in the Docker image, so icons and map controls render.Fixes #191.
How: esbuild emitted assets as
build/<asset>-<hash>.*, whiledistributeBuildFiles.jsonly copies files starting with the package name intopackages/<pkg>/build. Assets are now named<pkg>-<asset>-<hash>(viaassetNames), so they are picked up. The Dockerfile now also copiesyasgui-*.woff2andyasgui-*.png. Verified locally with a production build plusdistributeBuildFiles.js: everyurl()in the three package CSS files resolves to a file in that package'sbuild/directory. The Docker change was not built locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01KyMfexu5WafYRCzh4jhKu6
Generated by Claude Code