Repository navigation
merge from zazuko - #38
Merged
Merged
Conversation
Fix the `json.ts` parser for ASK queries when the `queryResponse` is a string
There was a problem hiding this comment.
Pull request overview
This PR merges changes from Zazuko that add a defensive check to the JSON parser to handle SPARQL ASK query responses. The change prevents errors when attempting to post-process bindings on query responses that don't contain a results field.
- Added null-safety check for
json.resultsbefore accessingjson.results.bindings - Ensures consistency between the two code paths (string and object responses) in the JSON parser
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.