Skip to content

<fix>[storage]: keep partial groups#4450

Open
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/tao.gan/ZSV-9792-r4@@2
Open

<fix>[storage]: keep partial groups#4450
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/tao.gan/ZSV-9792-r4@@2

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

APIImpact

Resolves: ZSV-9792

Change-Id: I6c6b656d77706671687561696d7669777863646f

sync from gitlab !10413

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 41b2728d-1826-4baf-b61f-149bdda2e849

📥 Commits

Reviewing files that changed from the base of the PR and between e93a4ac and a77e9c4.

⛔ Files ignored due to path filters (1)
  • conf/serviceConfig/volumeSnapshot.xml is excluded by !**/*.xml
📒 Files selected for processing (15)
  • header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotOverlayInnerReply.java
  • header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotReply.java
  • header/src/main/java/org/zstack/header/storage/snapshot/group/APIGetVolumeSnapshotGroupTreeMsg.java
  • header/src/main/java/org/zstack/header/storage/snapshot/group/APIGetVolumeSnapshotGroupTreeMsgDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/storage/snapshot/group/APIGetVolumeSnapshotGroupTreeReply.java
  • header/src/main/java/org/zstack/header/storage/snapshot/group/APIGetVolumeSnapshotGroupTreeReplyDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/storage/snapshot/group/VolumeSnapshotGroupTreeInventory.java
  • header/src/main/java/org/zstack/header/storage/snapshot/group/VolumeSnapshotGroupTreeInventoryDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/storage/snapshot/group/VolumeSnapshotGroupTreeRefInventory.java
  • header/src/main/java/org/zstack/header/storage/snapshot/group/VolumeSnapshotGroupTreeRefInventoryDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/volume/APICreateVolumeSnapshotGroupMsg.java
  • storage/src/main/java/org/zstack/storage/snapshot/VolumeSnapshotManagerImpl.java
  • storage/src/main/java/org/zstack/storage/snapshot/group/VolumeSnapshotGroupBase.java
  • storage/src/main/java/org/zstack/storage/snapshot/group/VolumeSnapshotGroupTreeBuilder.java
  • storage/src/main/java/org/zstack/storage/volume/VolumeBase.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/tao.gan/ZSV-9792-r4@@2

Comment @coderabbitai help to get the list of available commands.

APIImpact

Resolves: ZSV-9792

Change-Id: I6c6b656d77706671687561696d7669777863646f
@MatheMatrix MatheMatrix force-pushed the sync/tao.gan/ZSV-9792-r4@@2 branch from 4becc08 to c70a9b6 Compare July 6, 2026 02:13
Root cause: the group tree response was modeled as a query inventory, which can conflict with the normal volume snapshot group query mapping and return the wrong inventory type.

Solution: expose the group tree as a dedicated API get message, build the tree in the snapshot service, and keep tree inventories outside the generic query inventory mapping.

Impact: this changes the group tree API message type from query to get while preserving the existing REST path and returning only the tree inventory payload.

APIImpact

Resolves: ZSV-9792

Change-Id: I696867747a666d6d6967686f66696278776b6f63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants