Skip to content

<fix>[platformservice]: update upload SDK metadata#4483

Open
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/taiyue.chen/ZSV-12505@@2
Open

<fix>[platformservice]: update upload SDK metadata#4483
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/taiyue.chen/ZSV-12505@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Expose platform service local upload fields and long job result metadata in generated SDK classes.

Resolves: ZSV-12505

Change-Id: I1250500000000000000000000000000000000001

sync from gitlab !10445

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7658a339-9c84-4e03-b395-5f72ead8f26f

📥 Commits

Reviewing files that changed from the base of the PR and between bfddd8b and e7ab69b.

📒 Files selected for processing (3)
  • sdk/src/main/java/org/zstack/sdk/platformservice/PlatformServicePackageInventory.java
  • sdk/src/main/java/org/zstack/sdk/platformservice/UploadPlatformServicePackageAction.java
  • sdk/src/main/java/org/zstack/sdk/platformservice/UploadPlatformServicePackageResult.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/taiyue.chen/ZSV-12505@@2

Comment @coderabbitai help to get the list of available commands.

Expose local upload fields and long job result metadata.

Update generated SDK classes.

Resolves: ZSV-12505

Change-Id: I5f36a2a4d7d11b5048736715e6aa5f5357185e8e
@MatheMatrix MatheMatrix force-pushed the sync/taiyue.chen/ZSV-12505@@2 branch from 0bcb534 to e7ab69b Compare July 7, 2026 14:24
@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Comment from yaohua.wu:

Review: MR !10445 — ZSV-12505

Background (preserved across rounds)

  • Jira: ZSV-12505 — 平台服务支持ZLR、ZCenter部署
  • Bug summary: 本组 MR 在既有平台服务部署能力上补齐本地安装包上传与长任务元数据。Jira 描述较少,主要参考前序平台服务后端设计与已合并的平台服务插件/SDK MR。
  • Intent & scope: zstack 侧只更新 generated SDK metadata:暴露 uploadFileUrllongJobInventorylongJobNamelongJobDescription,供 premium 侧平台服务包上传长任务使用。
  • Round 1 initial findings: 0 × Critical, 0 × Warning in zstack SDK metadata;联合审查中 premium MR !14641 有 1 个 Critical。
  • Suggested fix direction: zstack SDK 字段保持与 premium API 契约同步;先修复 premium 侧重启恢复路径后再合并本组 MR。

关联 MR

MR 关系
http://dev.zstack.io:9080/zstackio/premium/-/merge_requests/14641 实现平台服务包本地上传、LongJob 生命周期、备份存储 tracker;本 MR 的 SDK 字段依赖该 API 契约。

Findings

Severity File:Line Issue Fix
- - zstack SDK metadata 与 premium API 新增字段对齐,未发现本仓需修改项。 无需修改本 MR;但本组联合变更需等待 premium MR !14641 的 Critical 修复。

Cross-Repo Check

Item Result
longJobName / longJobDescription premium API 继承 APICreateLongJobMessage 后,zstack SDK 已生成同名可选字段。
longJobInventory premium event 新增字段,zstack SDK result 已新增 LongJobInventory longJobInventory
uploadFileUrl premium inventory 新增字段,zstack SDK inventory 已新增 uploadFileUrl
Joint blocker premium !14641 的非 upload:// 重启恢复路径会卡住 package 状态,本组 MR 不应单独合并。

Upstream Freshness

Repo Result
zstack zsv_5.1.0 相对 MR base 无新增提交;本 MR 3 个 SDK 文件无 freshness 冲突。

Coverage

Item Result
Reviewed files 3 / 3 SDK metadata files
Generated-file filter 0 skipped, kept 3 / total 3
Local verification git diff --check passed
Testing gaps 本仓仅为 generated SDK metadata,未运行集成测试;功能风险集中在 premium MR !14641。

Verdict: REVISION_REQUIRED

本 MR 本身未发现需改动项;联合变更仍被 premium MR !14641 的 Critical 阻塞。


🤖 Robot Reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants