Skip to content

<fix>[lb]: add slb vip nic error code#4498

Open
ZStack-Robot wants to merge 1 commit into
feature-5.5.28-lb-ipvsfrom
sync/dejing.liu/codex/sug-2795-slb-error-code
Open

<fix>[lb]: add slb vip nic error code#4498
ZStack-Robot wants to merge 1 commit into
feature-5.5.28-lb-ipvsfrom
sync/dejing.liu/codex/sug-2795-slb-error-code

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Add ORG_ZSTACK_NETWORK_SERVICE_SLB_10058 for the SLB VM VIP owner NIC validation failure.

This is the ZStack companion MR for premium !14644.

Test: mvn -pl utils -DskipTests install

Resolves: ZSTAC-86152

sync from gitlab !10459

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 54 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9f3e5004-9227-4138-9131-47a898d1cc2f

📥 Commits

Reviewing files that changed from the base of the PR and between f74891d and 94f27d3.

📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

在 CloudOperationsErrorCode.java 中新增一个公开静态常量 ORG_ZSTACK_NETWORK_SERVICE_SLB_10058,其字符串值与常量名相同,用于表示新的 SLB 网络服务错误码。

Changes

错误码常量新增

Layer / File(s) Summary
新增SLB错误码常量
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
新增公开静态字符串常量 ORG_ZSTACK_NETWORK_SERVICE_SLB_10058,值与常量名相同。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

一行常量轻轻添,
SLB错误码入档案,
兔子蹦跳把码编,
代码库中静静眠。
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题准确概括了新增 SLB VIP NIC 错误码这一主要变更。
Description check ✅ Passed 描述与本次变更一致,说明了新增错误码、测试和关联工单。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/dejing.liu/codex/sug-2795-slb-error-code

Comment @coderabbitai help to get the list of available commands.

@MatheMatrix MatheMatrix force-pushed the sync/dejing.liu/codex/sug-2795-slb-error-code branch from f74891d to 5c94a4a Compare July 8, 2026 09:49
Add dedicated SLB error codes for VIP owner NIC lookup and
SLB VM config /createvip runtime failure. Keep these paths
distinct from the existing SLB createvip sync flow error code.

Test: mvn -pl utils -DskipTests install

Resolves: ZSTAC-86152
Change-Id: Ifebfb16bb8b402e448be98df31fe603a524940a3
@MatheMatrix MatheMatrix force-pushed the sync/dejing.liu/codex/sug-2795-slb-error-code branch from 5c94a4a to 94f27d3 Compare July 8, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant