fix(dedup): scope content hashes by account - #2
Open
smitzo wants to merge 1 commit into
Open
Conversation
smitzo
marked this pull request as ready for review
August 10, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_idwhen one is availableRoot cause
FITID-based deduplication already keys transactions by
(account_id, fitid), but the fallback content hash used only date, signed amount, currency, and canonical description. Two transactions from different accounts could therefore receive the same fallback identity and one would be silently discarded during a multi-statement merge.For example, matching MT940 entries from
ACCOUNT-AandACCOUNT-Bpreviously merged into one row even though both source statements parsed successfully.Impact
Identical-looking transactions from different known accounts are now preserved. Transactions from the same account continue to deduplicate normally.
Compatibility
The account ID is added to the hash only when present, so existing hashes for CSV, QIF, text, or other account-less transactions remain unchanged. Hashes for account-aware transactions intentionally become account-scoped.