Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCO listing runs previously emitted empty placeholder records for failed pages, counted them toward the document limit, and used source-specific CLI dispatch that could stop
--source allearly. This ports the scraper from #17 onto the shared registry and listing contract on current main, so failed pages are logged/skipped and only successful documents count.ccoextra, gate imports, and document Chromium installation. Normal runtime imports work without Playwright.summary; linked PDF bodies are not converted.codex/prefix in AGENTS.md. Keep the existing uv lockfile tracked.Continues #17 and addresses its review comments: dependency declaration, all-source dispatch, and failed documents counted as success. The original PR remains open for its review history.
Validation:
uv run ruff check .,uv run ruff format --check .,uv run pytest -q(70 passed), anduv build --package amfv-datasets. A fresh install without Playwright successfully imports the CLI and reports actionable installation instructions when CCO is invoked. Live checks scraped one explicit URL and two listing documents; the complete corpus was not run.