feat: add Dada Devs as a learning partner - #45
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hello bro, the Dada Devs integration is structured well overall, and CI is green, but I found two correctness issues I think should be addressed before merge. 1. Hidden partner guard is missing on the new dedicated pageIn const partner = getPartnerBySlug("dada-devs");
if (!partner) return null;
Because I think this should follow the existing dedicated-page invariant: import { notFound } from "next/navigation";
const partner = getPartnerBySlug("dada-devs");
if (!partner || partner.hidden) {
notFound();
}2. Org-wide DB skills erase the distinction between the two Dada pathwaysHere: skills={dbSkills.length > 0 ? dbSkills : journey.skills}
That conflicts with The existing Thebuidl implementation did not expose this problem because it only had one journey. With Dada Devs introducing multiple pathways, the distinction matters. For this public pathway UI, the minimal fix seems to be: skills={journey.skills}and continue using org-level skills in the authenticated partner hub/opportunity matching. I would avoid introducing pathway-specific DB schema here unless the product actually needs admin-managed per-pathway skills. One additional scope questionThis PR also removes Thebuidl's complete "Put your skills to work" section, including That is a larger user-visible behavior change than the CTA cleanup described in the PR summary. The authenticated partner hub still exposes suggested opportunities, so moving repository discovery behind membership may be intentional. If it is intentional, I think the PR description/test plan should call it out explicitly. Otherwise, this section should probably remain unchanged in a PR focused on adding Dada Devs. Everything else I checked is consistent with the current partner architecture, and the full PR CI is passing. |
|
Hi brother @comwanga ... thanks for the thorough review, you're right on both counts, fixed:
Pushing the fixes now. |
Summary
pathways (Mastering Bitcoin, Mastering Lightning), following the same
pattern as Thebuidl.
/ecosystem/partners/dada-devs— hero, About +DadaHub (Nairobi) photo, pathway cards in a two-column grid, how-it-works,
and participant CTA. Links out to dadadevs.com, GitHub, and the
dadadevs.com/pathways application page.
row.
(thebuidl.xyz/rust-for-bitcoin).
right-aligns on desktop, journey-diagram arrows were invisible in light
mode (fixed contrast), removed redundant/dead invite-CTA text from
PartnerCurrentJourney/PartnerInviteCta, and added alogoScalefieldso differently-proportioned partner logos can be sized consistently.
Test plan
/ecosystem/partners/dada-devsrenders correctly in light and dark mode/ecosystem/partners/thebuidlhas no regressions (hero alignment, apply link, arrow contrast)/ecosystem/partnersindex and homepage "Trusted By" row show the Dada Devs logo correctlynpx tsc --noEmitandeslintpass