Development Branch and Refactor Home - #7
Open
MelissaHarper wants to merge 38 commits into
Open
MelissaHarper wants to merge 38 commits into
MelissaHarper wants to merge 38 commits into
Conversation
Wrap items whose props rarely/don't change to avoid superfluous re-rendering
Add hardcoded error modal for development site when backend is unavailable.
Added while loop to return pages with at least 5 results or page 1 Added page countdown to reduce number of API calls Added error message if no results are returned from given filters
Added documentation and changed variable names to be more descriptive
Renamed ErrorModal to AlertModal and call-functions.js to tmdb-call-functions.js Updated references
✅ Deploy Preview for harper-pickquick ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched off of previously unmerged development branch. Only the commit from Sept 15 is described below
Removed tailwind for filters to start making styling consistent throughout site.
Changed filters from a context provider to functional components
Reordered layout
Added getRecommendationsContainer that composes a dynamic sentence according to filters selected and contains buttons to get recommendations or clear filters
Removed commented keyword filter until future development