Repository navigation
Conversation
… required (operator, 2026-10-19)
…tes, CLAUDE.md bridge paragraph (PR #61)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
design/90 block 90a. Closes register rows R155 and R158. LOCAL gate: full local suite plus Ubuntu and Windows CI.
R155. In
_acquire_with_hooks, a Ctrl-C delivered during the teardown wait now hands teardown to the waiter, just as an expiry does. It writes the pending record and grants the waiter reservation closure, then re-raises. Before this change no pending record was written at all, so the next acquisition was not refused whileAcquisition.__exit__was still running. The wait is on anEventthatfinish()sets in its outermostfinally._join_acquisition_waiterand 88a's_wait_mda_completionare folded into a single_wait_acquisition_completion. The pending record carriesdoneinstead ofwaiter, andexecute_toolreadsdone.is_set(). Nothing readsis_alive()after an interruptible join any more.R158. The final
displayed(output, 3)check now useswait_until(..., describe).Evidence
test_real_interrupt_hands_blocked_teardown_and_reservation_to_waiterdelivers a real_thread.interrupt_main()while the foreground is inside its wait. On the pre-fixtools.py(2e5b7e2) it fails at the refusal:AssertionError: {'ok': True}. With the fix it passed 30 of 30 runs.is_alive()sites cannot be reached by a main-thread Ctrl-C. That comes from reading the code, not from measurement, and is tabulated in design/90.Also in this PR: R159's Importance becomes "recommended before 89b, not required" (operator decision, 2026-10-19).