investigate scaled Windows native probe coordinates (blocked) by Microck · Pull Request #349 · Microck/satelle

Microck · 2026-10-03T11:31:09Z

do not merge: the proposed dpi change failed native acceptance.

all platform tests, builds, npm/docs checks and the exact-head full review pass. the full review generated no actionable findings. that does not establish native input correctness.

the original per-monitor-aware probe is 1024 by 678 physical pixels. at 175% scaling, the native sdk rejects (660,430) against logical bounds585x387. making only the probe owner thread dpi-unaware removes that bounds error, but it scales the button and drag targets while the sdk continues placing input in physical pixels.

an independent observer on the active desktop matched the exact ci binary by sha256. it measured a 1792 by1187 physical window and 1024 by678 logical window. the tool placed the click at physical (190,142) relative to the window; the scaled button starts at physical y201. the cursor then moved to physical (660,430). both private status labels stayed pending. the exact native tool completed successfully, while readiness timed out. three candidate tests remain blocked.

this change is not a fix. the evidence points to inconsistent native sdk validation and input coordinate units. no callbacks were bypassed, no display settings changed, and no community binary patch applied. private errors and geometry proofs are saved. stacked on #346; neither this candidate nor the release has been merged or published.

vercel · 2026-10-03T11:31:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
satelle	Ready	Preview	Oct 3, 2026 11:31am UTC

coderabbitai · 2026-10-03T11:31:17Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: Microck/satelle/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 47b8ef95-efeb-4cab-9ef9-235c58559c3b

📥 Commits

Reviewing files that changed from the base of the PR and between 738f4e3 and e1e83ff.

📒 Files selected for processing (4)

.facts
crates/satelle/src/host/runtime-codex-adapter.rs
crates/satelle/src/host/windows-native-probe.rs
docs/reference/codex-app-server-capability-matrix.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The Windows native readiness probe now creates its borderless 1024 × 678 surface on a DPI-unaware thread. The geometry test and descriptions reflect logical-pixel behavior. The probe still requires both native callbacks.

Changes

Windows readiness probe

Layer / File(s)	Summary
DPI-unaware window and geometry checks `crates/satelle/src/host/windows-native-probe.rs`, `crates/satelle/src/host/runtime-codex-adapter.rs`, `docs/reference/codex-app-server-capability-matrix.md`, `.facts`	The probe sets its window thread to DPI-unaware mode. Windows scales the logical layout and input coordinates. The geometry test checks for an unaware window, and the comment and capability matrix describe logical-pixel geometry. The 1024 × 678 layout and requirement for both native callbacks remain.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e1e83

No actionable issue was identified in the logical-coordinate change. Windows platform validation remains pending as a normal check before release.

Architecture Summary

Architecture risk: 🔵 Low · up to e1e83

The change affects 2 systems.

Changed systems: crates, docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — crates (service) was modified; 2 changed files map to changed impact.
observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in crates/satelle/src/host/runtime-codex-adapter.rs: The comment changes the Windows native probe layout description from borderless physical pixels to borderless logical pixels shared with the SDK.
observed — Modified behavior in crates/satelle/src/host/windows-native-probe.rs: The imported DPI context changes from DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 to DPI_AWARENESS_CONTEXT_UNAWARE; SetThreadDpiAwarenessContext remains imported.
observed — Modified behavior in crates/satelle/src/host/windows-native-probe.rs: run_window now sets its thread to DPI-unaware instead of per-monitor-v2. Windows therefore scales this transient window’s logical layout and input coordinates; failure still sends the OS error to the readiness sender and exits.
observed — Modified behavior in crates/satelle/src/host/windows-native-probe.rs: The geometry test is renamed to describe SDK logical coordinates rather than physical-pixel geometry.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to the Windows native probe and its scaled coordinates, which are central to the change. However, "investigate" and "blocked" do not describe the implemented DPI-awareness change.

Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Microck · 2026-10-03T11:31:20Z

@coderabbitai full review

coderabbitai · 2026-10-03T11:31:28Z

⚠️ Action not completed

Review rate limited.

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 11 minutes.

Microck · 2026-10-03T11:43:06Z

@coderabbitai full review

coderabbitai · 2026-10-03T11:43:14Z

✅ Action performed

Full review finished.

Microck added 2 commits October 2, 2026 20:33

fix(computer-use): use the Windows desktop native app-server

738f4e3

fix(computer-use): match Windows probe logical coordinates

e1e83ff

vercel Bot deployed to Preview October 3, 2026 11:31 View deployment

Microck mentioned this pull request Oct 3, 2026

fix(computer-use): use the Windows desktop native app-server #346

Open

Microck changed the title ~~fix(computer-use): match Windows probe logical coordinates~~ investigate scaled Windows native probe coordinates (blocked) Oct 3, 2026

Microck force-pushed the fix/windows-native-desktop-runtime branch from 738f4e3 to 27dfc09 Compare October 3, 2026 16:53

Navigation Menu

investigate scaled Windows native probe coordinates (blocked) - #349

investigate scaled Windows native probe coordinates (blocked)#349
Microck wants to merge 2 commits into
fix/windows-native-desktop-runtimefrom
fix/windows-probe-coordinates

Microck commented Oct 3, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

Microck commented Oct 3, 2026

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

Microck commented Oct 3, 2026

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Microck commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

❌ Failed checks (1 warning)

Uh oh!

Microck commented Oct 3, 2026

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Microck commented Oct 3, 2026

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Microck commented Oct 3, 2026 •

edited

Loading

vercel Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading