fix(recovery): archive interrupted inactive POSIX service restarts - #378
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Microck
force-pushed
the
fix/posix-interrupted-service-restart
branch
from
October 5, 2026 11:39
85bd2b6 to
e078b9e
Compare
Microck
force-pushed
the
fix/macos-recovery-service-probe
branch
from
October 5, 2026 11:39
e00b8d9 to
3a105ec
Compare
Microck
force-pushed
the
fix/posix-interrupted-service-restart
branch
from
October 5, 2026 11:46
e078b9e to
f58c7d6
Compare
Microck
force-pushed
the
fix/macos-recovery-service-probe
branch
from
October 5, 2026 11:46
3a105ec to
1af9eb8
Compare
Microck
force-pushed
the
fix/macos-recovery-service-probe
branch
from
October 5, 2026 12:22
1af9eb8 to
aa3f156
Compare
Microck
force-pushed
the
fix/posix-interrupted-service-restart
branch
from
October 5, 2026 12:22
f58c7d6 to
d3015f5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Codex responding on behalf of Microck
a mac can keep an interrupted persistent-service restart claim forever, even after its old wrapper has gone. a completed setup ledger does not prove that external restart succeeded, so recovery must preserve that unknown outcome.
recovery now permits another attempt only when two full process snapshots prove the old operation wrapper and service launchers absent, and daemon, service and listener are all inactive. unknown or oversized snapshots keep the fence. the exact stale claim and markers are checked again after quarantine, and the original claim plus mailbox move into a private archive without a fabricated success marker.
42 matching tests, formatting and workspace clippy passed in Crabbox. tests cover preservation of original output, active and unknown probes, and a helper appearing between snapshots. the generated-script vocabulary assertion was updated for the two new exact restart-phase checks; recovery assertions were not relaxed. live mac recovery remains pending, and its original claim is untouched.
stacked on #377, which fixes the mac service and process probes.