### 🔵 Needs a closer look

[MikeGrier]

🔵 Needs a closer look

The documents reuse the discharged SH-16.11 ID and claim all historical follow-ups are tracked despite missing checklist work.

Review details

Suppressed comments (4)

Previously missed (1) — in code that hasn't changed since the last review.

crates/topology-planner/DESIGN-NOTES.md:263

• The canonical note says the detailed trigger analysis is recorded in this rationale section, but the new section only retains a high-level summary: it omits the D-9 'demonstrably mismodels a machine' trigger, the single-node/vacuous measurement result, and why reopening that decision is still deferred. Restore those historical details here or change this pointer so the split does not claim rationale that was dropped.

crates/topology-planner/CHECKLIST.md:76

• SH-16.11 is already discharged and superseded by windows-topology-sys D-20; it specifically tracked filling the deleted distances field. Reusing that archived ID for the new directed-cost contract makes the open work look closed and conflicts with the owning checklist. Allocate a new component-owned work ID and update the active tracker instead.

  remains tracked as `SH-16.11`.

crates/topology-planner/DESIGN-NOTES.md:258

• This repeats SH-16.11 as the open tracking ID, but that ID was discharged and superseded by D-20 when MachineMemoryTopology::distances was deleted. Give the abstract-model directed-cost requirement a new work ID rather than reusing the historical topology-sys item.

The directed-cost half remains an open requirement on `topology-model` plus adapter inputs and stays
tracked as `SH-16.11`.

crates/topology-planner/DESIGN-RATIONALE.md:26

• This says all three historical follow-ups are tracked in the component checklist, but the checklist has no item for measurement ownership, and its naming item covers planner/model naming rather than adapter naming. Add explicit checklist work for the missing follow-up or narrow this sentence so the design rationale does not claim unscheduled work is tracked.

These are tracked as checklist work in [CHECKLIST.md](CHECKLIST.md) rather than as canonical
decisions.

• Files reviewed: 7/7 changed files
• Comments generated: 0 new
• Review effort level: Lite

Originally posted by @Copilot in #100 (review)