You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR ensures MCP indexes get validated on every query like the CLI route. There's a minimum time (3x original indexing time) to ensure we don't start re-indexing while it's still indexing).
Safe to merge — the staleness check is gated behind multiple guards (done task, non-cancelled, no exception, cooldown, identity check before evict) and all mutations to _revalidate_after now happen on the event loop thread.
The core logic is sound: cooldown is recorded after the asyncio.to_thread await (event-loop-thread write), the concurrent-replacement race is handled via identity comparison before eviction, git URLs are bypassed, and failed tasks are left alone. get_validated_cache already accepts str | None for model_path and resolves it internally, so the self._model_path type is compatible. Tests cover all the new code paths including the cooldown gate, failed-task skip, and concurrent-replacement scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures MCP indexes get validated on every query like the CLI route. There's a minimum time (3x original indexing time) to ensure we don't start re-indexing while it's still indexing).