Pair every query with a continuous version - #2
Open
estebanzimanyi wants to merge 1 commit into
Open
Conversation
Each query of the four scripts now has a discrete and a continuous version that run and whose answers are reported in the same shape, so that the two counts are directly comparable. A `_new` copy of each script carries the same queries annotated with the mechanism behind every difference, and QUERIES.md maps the queries of the paper to the queries of the repository. Queries that did not run - `atValues(tbool, value)` -> `atValue`, which is the form taking a scalar - the part-of-day query over the temporal tour segments, which was left unfinished, written with segments() and startTimestamp() - `p.BufferGeom` -> the geometry of the point of interest, and the distance measured at the start of the step with valueAtTimestamp() instead of at the start of the whole tour Queries that did not state the query - Query 9 restricts the trip to Pm25 > 125 and temperature > 20 before the episodes are searched, as the last line of its pattern requires - Query 16 requires the trip to enter the district through its boundary as well as to leave through it - the discrete district queries read the point-based sequence; the sequence derived from the trajectory belongs to the continuous version - the before of a tour pattern is `<<#`; comparing two temporal values with `<` orders them by bounding box and only coincides with before when the steps are disjoint Naming - complete trips use Q8..Q12, the grid uses GQ8..GQ14 so that the two scripts do not collide in the same database, districts use Q15 and Q16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every query of the four scripts has a discrete and a continuous version that runs, and both versions report their answer in the same shape, so the two counts are directly comparable. Each script has a
_newcopy carrying the same queries annotated with the mechanism behind every difference, andQUERIES.mdmaps the queries of the paper to the queries of this repository.All counts below come from a run against the
delhiandparisdatabases.API and query statement
atValueis the form that takes a scalar second argumentsegments()andstartTimestamp(), and returns the discrete answervalueAtTimestamp()TourPoIview ofparis_tours.sqlPm25 > 125and temperature above 20 degrees before it searches the episodes, as the last line of its own pattern requires<<#, since<orders temporal values by bounding box and agrees with before only while the steps are disjointWhat the pairs show
Complete trips agree almost everywhere (708/708, 94/94, 8/8, 71/71), as neither side aggregates. That agreement is what attributes the grid divergences to the per-cell averaging rather than to the query language:
Districts show the same effect at a larger granularity: 8957/9262 overlapping, 1891/1906 disjoint, 9903/10201 any-length. Query 16 has no discrete version and admits none: of the 7087619 observations, none lies on a district boundary, so
Meetsis never observed, and a tolerance yields 14397, 148525 or 640954 candidates at 1 m, 10 m and 50 m.Naming
Complete trips use
Q8..Q12, the gridGQ8..GQ14, districtsQ15andQ16. The grid carries theGprefix throughout because the bare names collide with the complete-trip script in the same database.